chore: Add copilot instructions - #15
Merged
Merged
Conversation
aymericmariaux
requested review from
baillyjamy
and
a balanced review from Copilot
August 6, 2026 14:06
There was a problem hiding this comment.
Pull request overview
Adds and corrects Copilot onboarding guidance for the Kotlin Multiplatform library.
Changes:
- Adds build, validation, architecture, and review instructions.
- Corrects namespace, package distribution, and JVM test commands.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
AGENTS.md |
Corrects project and testing documentation. |
.github/copilot-instructions.md |
Adds Copilot coding-agent onboarding guidance. |
Suppressed comments (2)
.github/copilot-instructions.md:42
appleTestis not a device-test source set: it feeds the iOS simulator and macOS test targets, which require a macOS host but not a physical device (also reflected byAGENTS.md:140-142). Labeling it as “device” can cause agents to skip runnable Apple tests or describe their validation requirements incorrectly.
# commonTest/androidHostTest (no device), androidDeviceTest/appleTest (device)
.github/copilot-instructions.md:29
- This contradicts line 21:
builddoes not fail on Linux merely because Apple targets are present; Kotlin/Native skips those unsupported targets, so the command can succeed with incomplete Apple validation. Only the XCFramework task requires macOS here. Reword this so agents do not incorrectly report thatbuilditself cannot be attempted on Linux.
macOS-only — do NOT attempt on Linux, they will fail; say so in the PR description instead of pretending they were verified:
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aymericmariaux
force-pushed
the
add-copilot-instructions
branch
from
August 6, 2026 14:13
0b00fd2 to
b5a1688
Compare
baillyjamy
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.