COMP: prefix CMake check commands with DCMTK_ to avoid leaking - #2
Merged
hjmjohnson merged 1 commit intoJun 22, 2026
Conversation
CHECK_FUNCTION_EXISTS (Windows override) and CHECK_CXX_SYMBOL_EXISTS (fallback) were defined as global CMake commands. When DCMTK is built via FetchContent inside another project, these overrides leaked into sibling modules and caused incorrect feature detection. Renamed to DCMTK_CHECK_FUNCTION_EXISTS and DCMTK_CHECK_CXX_SYMBOL_EXISTS and updated all call sites.
hjmjohnson
approved these changes
Jun 20, 2026
hjmjohnson
left a comment
hjmjohnson
left a comment
Member
There was a problem hiding this comment.
Looks good. Will you make an upstream PR for this after testing?
hjmjohnson
merged commit Jun 22, 2026
4ac9b44
into
InsightSoftwareConsortium:for/itk-dcmtk-3.7.0-ccfd10b
Member
Author
|
PR made for upstream DCMTK#153 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHECK_FUNCTION_EXISTS (Windows override) and CHECK_CXX_SYMBOL_EXISTS (fallback) were defined as global CMake commands. When DCMTK is built via FetchContent inside another project, these overrides leaked into sibling modules and caused incorrect feature detection.
Renamed to DCMTK_CHECK_FUNCTION_EXISTS and DCMTK_CHECK_CXX_SYMBOL_EXISTS and updated all call sites.