Skip to content

fix(deps): pin tao to the upstream Wayland CSD fix commit#428

Merged
InstaZDLL merged 1 commit into
mainfrom
fix/tao-wayland-titlebar-buttons
Jul 23, 2026
Merged

fix(deps): pin tao to the upstream Wayland CSD fix commit#428
InstaZDLL merged 1 commit into
mainfrom
fix/tao-wayland-titlebar-buttons

Conversation

@InstaZDLL

@InstaZDLL InstaZDLL commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • GNOME/Wayland title bar buttons (minimize/maximize/close) are unresponsive on tao < 0.36.0 — a known upstream bug (tauri-apps/tao#1218).
  • The fix merged to tao's main branch on 2026-06-29 but hasn't been published as a crates.io release yet (latest published is still 0.35.3).
  • Pins tao/tao-macros to the merge commit via [patch.crates-io] (same mechanism already used for the glib 0.18.5 backport, see the existing comment in Cargo.toml) so the fix ships now instead of waiting on an unscheduled tao release.
  • This is a temporary pin — documented inline to be removed once tao ≥ 0.36.0 is published on crates.io (tauri's existing ^2.11.4 tauri-runtime-wry range already accepts it, no version bump needed on our side at that point).

Test plan

  • cargo check --workspace --all-targets — green
  • cargo test --workspace — blocked locally by disk space (unrelated to this change); relying on CI
  • Manual: confirm title bar buttons respond on GNOME Wayland once this ships in a build

Closes #427

GNOME/Wayland title bar buttons (minimize/maximize/close) are
unresponsive on tao < 0.36.0 — a known bug fixed in
tauri-apps/tao#1218, merged to tao's main branch 2026-06-29 but not
yet published as a crates.io release (still 0.35.3). Pin tao/tao-macros
to the merge commit via [patch.crates-io] so the fix ships now instead
of waiting on an unscheduled tao release; the pin is documented as
temporary and should be dropped once tao >= 0.36.0 lands on crates.io.

Closes #427
@InstaZDLL InstaZDLL added scope: backend Rust/Tauri backend (src-tauri/) scope: deps Dependencies type: fix Bug fix size: m 50-200 lines labels Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

La configuration Cargo ajoute un override de tao vers un commit Git précis afin d’inclure un correctif CSD pour GNOME/Wayland, avec une note indiquant le retrait du pin après publication de la version correspondante.

Changes

Correctif tao GNOME/Wayland

Layer / File(s) Summary
Override Cargo de tao
src-tauri/Cargo.toml
La section [patch.crates-io] force tao à être résolu depuis un dépôt Git et une révision spécifiques, avec le contexte du correctif et son retrait prévu.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed Le titre est clair, court et reflète bien le pin temporaire de tao pour corriger le bug Wayland.
Description check ✅ Passed La description couvre le résumé, les tests et le lien d’issue; seuls les blocs checklist et captures sont partiellement ou non renseignés.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/tao-wayland-titlebar-buttons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@InstaZDLL
InstaZDLL merged commit 280fc0f into main Jul 23, 2026
14 checks passed
@InstaZDLL
InstaZDLL deleted the fix/tao-wayland-titlebar-buttons branch July 23, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: backend Rust/Tauri backend (src-tauri/) scope: deps Dependencies size: m 50-200 lines type: fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Title bar buttons (min, max and close) don't work

1 participant