feat(scan): show the current directory in the scan progress toast (#430)#432
Merged
Conversation
The progress toast already surfaced a counter + percentage bar, but a bare "N / M files" gives no sense of where the scan is. Add current_dir to the scan:progress payload — the parent directory of the file just processed — and render a live "…/Parent/Album" line under the bar so the user can watch the scan walk through folders. current_dir is None on the initial + final ticks, which carry no specific file. New i18n key scanProgress.scanningIn propagated to all 17 locales.
InstaZDLL
added
scope: frontend
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughLe scan transmet désormais le répertoire courant dans ChangesProgression de scan en direct
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Scanner
participant ScanProgress
participant ScanProgressToast
participant TranslationCatalog
Scanner->>ScanProgress: émet current, total, compteurs et current_dir
ScanProgress->>ScanProgressToast: transmet l’événement scan:progress
ScanProgressToast->>ScanProgressToast: extrait le libellé du répertoire
ScanProgressToast->>TranslationCatalog: demande scanningIn
TranslationCatalog-->>ScanProgressToast: retourne le texte localisé
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src-tauri/crates/app/src/commands/scan.rs`:
- Around line 1176-1183: Ensure the error branches in the scan loop emit
progress after incrementing summary.errors. In the handling of Ok(Err(_)) and
Err(_), call maybe_emit_progress with the current path before each continue,
preferably through a shared helper to avoid duplication; preserve the existing
successful extraction progress behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 9c7eb4fb-746d-41c4-a366-3b4fc2785195
📒 Files selected for processing (20)
docs/features/library.mdsrc-tauri/crates/app/src/commands/scan.rssrc/components/common/ScanProgressToast.tsxsrc/i18n/locales/ar.jsonsrc/i18n/locales/de.jsonsrc/i18n/locales/en.jsonsrc/i18n/locales/es.jsonsrc/i18n/locales/fr.jsonsrc/i18n/locales/hi.jsonsrc/i18n/locales/id.jsonsrc/i18n/locales/it.jsonsrc/i18n/locales/ja.jsonsrc/i18n/locales/ko.jsonsrc/i18n/locales/nl.jsonsrc/i18n/locales/pt-BR.jsonsrc/i18n/locales/pt.jsonsrc/i18n/locales/ru.jsonsrc/i18n/locales/tr.jsonsrc/i18n/locales/zh-CN.jsonsrc/i18n/locales/zh-TW.json
The Phase 2 error arms (Ok(Err) / Err) incremented summary.errors then continue'd without emitting, so a run of failed extractions froze the toast counter and error tally until the next success. Add a shared emit_tick closure — used by both error arms and the success path — so progress advances uniformly. Captures only Copy handles, stays a plain Fn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #430.
Problem
The scan progress toast already had a counter + percentage bar, but a bare N / M files gives no sense of where the scan actually is — the user's ask was to "see progressing thru the folder with changing directories".
Change
scan.rs): addcurrent_dir: Option<String>to thescan:progresspayload — the parent directory of the file just processed. Filled at bothmaybe_emit_progresssites (Phase 1 skip fast-path + Phase 2 extract loop);Noneon the initial + final ticks, which carry no specific file. Throttle unchanged (every 25 files).ScanProgressToast.tsx): render a live "…/Parent/Album" line under the bar — last two path segments for readability, full path in thetitletooltip.scanProgress.scanningInkey propagated to all 17 locales.docs/features/library.md.Validation
bun run typecheck✅bun run lint✅cargo clippy -p waveflow --all-targets✅Small, additive change — an optional field on an existing event and one extra line in an existing toast. No new command, no schema change.
Summary by CodeRabbit