Fix dpnp.mgrid/dpnp.ogrid inconsistency for complex steps with non-integer magnitude#2971
Merged
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Collaborator
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev1=py313h509198e_29 ran successfully. |
vlad-perevezentsev
approved these changes
Jun 25, 2026
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
github-actions Bot
added a commit
that referenced
this pull request
Jun 25, 2026
…n-integer magnitude (#2971) For a complex step, the integer part of its magnitude is the number of points to generate (start and stop inclusive). The single-slice and tuple-of-slices code paths disagreed when the step magnitude was **not** an integer (e.g. `2.5j`): - the tuple path used `int(abs(step)) - 1` as the divisor (correct), while - the single-slice path used the float magnitude `abs(step) - 1` as the divisor. As a result `dpnp.mgrid[0:10:2.5j]` and `dpnp.mgrid[0:10:2.5j,]` produced different arrays, and the single-slice form disagreed with NumPy. ```python >>> dpnp.mgrid[0:10:2.5j] # before: [0. , 6.667] after: [ 0., 10.] >>> dpnp.mgrid[0:10:2.5j,][0] # always: [ 0., 10.] (matches NumPy) ``` 09ff0a8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a complex step, the integer part of its magnitude is the number of points to generate (start and stop inclusive). The single-slice and tuple-of-slices code paths disagreed when the step magnitude was not an integer (e.g.
2.5j):int(abs(step)) - 1as the divisor (correct), whileabs(step) - 1as the divisor.As a result
dpnp.mgrid[0:10:2.5j]anddpnp.mgrid[0:10:2.5j,]produced different arrays, and the single-slice form disagreed with NumPy.