fix : Repeated message regarding missing tags#590
Merged
Conversation
- Skip versions whose resolved commit is already tagged under the un-prefixed name, so repos restructured into a subdir don't get duplicate prefixed tags/releases backfilled for pre-move history - Return None from _commit_sha_of_tree when a tree matches both the subdir cache and the root-tree cache (content-preserving move): either cache may point at the wrong commit, so defer to the registry PR, which pins the exact registered commit - Extract _build_subdir_tree_to_commit_cache, derived from the full tree cache: one git log pass populates both caches, per-commit rev-parse calls are deduped by root tree, and git failures degrade gracefully like the sibling builder - Check the root tree (already in hand from the API) before shelling out to rev-parse in _commit_sha_from_registry_pr, and share one root-tree comparison/warning between the subdir and regular paths - Update subdir tests to the single-pass cache format, replace the dead-setup cache-preference test with an ambiguity test, and cover the un-prefixed-tag guard Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
Claude found some issues and fixed them, can you review |
Collaborator
Author
I approve. |
IanButterworth
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.