[906] Frontend: Add robust form validation for deposit/withdraw flows - #919
Merged
Conversation
Align amount rules with API precision, validate before review, use vault holdings for withdraw balances, and revalidate on change. Closes Junirezz#906
Add deposit/withdraw schema cases for API AmountSchema parity and withdraw XLM fees, and fix pre-existing frontend unit test failures that blocked Monorepo CI. Narrow scripts vitest config to the env validation suite. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@Max-Owolabi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Clear eslint errors that fail Monorepo CI, migrate api-schemas to Node16 module resolution for modern TypeScript, and bump ethnum to 1.5.3 so Rust docs compile on current stable. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AmountSchema(max 7 decimals, no scientific notation) via sharedparseAmountInputFRONTEND_FORM_VALIDATION.md), schema/component coverage, and fix pre-existing frontend unit failures that blocked Monorepo CICloses #906
Test plan
cd frontend && npm run test:run(740 tests)cd frontend && npm run buildcd frontend && npm run lintnpm run test:validate-frontend-env