Skip to content

Stop tracking go.work.sum#28

Merged
KARTIKrocks merged 1 commit into
mainfrom
chore/ignore-go-work-sum
Jul 10, 2026
Merged

Stop tracking go.work.sum#28
KARTIKrocks merged 1 commit into
mainfrom
chore/ignore-go-work-sum

Conversation

@KARTIKrocks

Copy link
Copy Markdown
Owner

Go writes go.work.sum lazily, only for sums the per-module go.sum files cannot supply on their own. That happens when workspace-wide minimal version selection lifts a dependency above what an individual module requires — precisely the skew that makes make test pass while a consumer's build fails. Committing the file absorbs that skew silently; leaving it out makes the build report it.

Verified redundant today: with the file deleted, all fourteen packages across the ten modules build and test clean under the workspace, and Go does not recreate it.

Summary

What does this PR change, and why?

Closes #

Type of change

  • Bug fix
  • New detection rule
  • New integration / parser
  • Feature / enhancement
  • Docs only
  • Refactor / chore

Checklist

  • make ci passes (fmt-check, vet, lint, test-race) across all modules
  • Added/updated tests (and, where practical, a failure-mode check)
  • Updated docs as needed (README.md, AGENTS.md, .sqlguard.example.yml)
  • Added an entry under ## [Unreleased] in CHANGELOG.md
  • No new third-party deps in analyzer / middleware / reporter
  • Findings stay redaction-safe (no raw literals leak into a Result)

Notes for reviewers

Anything reviewers should focus on — tricky areas, trade-offs, follow-ups.

Go writes go.work.sum lazily, only for sums the per-module go.sum files cannot
supply on their own. That happens when workspace-wide minimal version selection
lifts a dependency above what an individual module requires — precisely the skew
that makes `make test` pass while a consumer's build fails. Committing the file
absorbs that skew silently; leaving it out makes the build report it.

Verified redundant today: with the file deleted, all fourteen packages across the
ten modules build and test clean under the workspace, and Go does not recreate it.
@KARTIKrocks KARTIKrocks merged commit b2dde4d into main Jul 10, 2026
14 checks passed
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@KARTIKrocks, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d4cef022-c3fa-463b-94d8-aa2574f96fe8

📥 Commits

Reviewing files that changed from the base of the PR and between 2670f18 and 866c8ff.

⛔ Files ignored due to path filters (1)
  • go.work.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • .gitignore
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/ignore-go-work-sum

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KARTIKrocks KARTIKrocks deleted the chore/ignore-go-work-sum branch July 10, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant