fix: show updater progress and enforce timeouts - #10
Merged
Conversation
Karl-Dai
marked this pull request as ready for review
August 14, 2026 05:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The updater waited on network requests and silently downloaded the complete update package before opening the update dialog. With no request timeout or visible progress, the button could remain on “Checking…” long enough to look unresponsive.
User impact
Users now see whether the app is checking, downloading, or verifying an update. Known-length downloads show a percentage, stalled checks/downloads fail with localized guidance, and duplicate checks are prevented while background update work is active.
Validation
npm -w shared-frontend test— 20 tests passednpm -w frontend run buildnpm -w master-frontend run buildcargo test -p modbusmaster-app -p modbussim-appcargo clippy -p modbusmaster-app -p modbussim-app --all-targets -- -D warningscargo tauri build --bundles app --config '{"bundle":{"createUpdaterArtifacts":false}}'