Check that VulkanHeaders_VERSION exists before use - #1984
Merged
charles-lunarg merged 1 commit intoJul 22, 2026
Merged
Conversation
When a project uses add_subdirectory to add the Vulkan-Headers, the lack of install causes VulkanHeaders_VERSION to not be defined. Since there is no easy way to get the version, simply disable the check if that variable isn't defined.
|
CI Vulkan-Loader build queued with queue ID 50639. |
|
CI Vulkan-Loader build queued with queue ID 50656. |
Collaborator
Author
|
Fixes #1983 |
|
CI Vulkan-Loader build # 3656 running. |
|
CI Vulkan-Loader build # 3656 passed. |
Collaborator
Author
|
The MacOS failing job is a known issue that exists with CMake. There isn't a good workaround (other than disabling parallelism) so I'm ignoring it and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a project uses add_subdirectory to add the Vulkan-Headers, the lack of install causes VulkanHeaders_VERSION to not be defined. Since there is no easy way to get the version, simply disable the check if that variable isn't defined.