Add CMake package/dependency find modules to template project#361
Closed
dorileo wants to merge 1 commit into
Closed
Add CMake package/dependency find modules to template project#361dorileo wants to merge 1 commit into
dorileo wants to merge 1 commit into
Conversation
Avoid frustration for newcomers and offer a last resort for resolving dependencies. The dependencies install script may fail in certain OSes or distributions, adding the find modules to template project improves the experience once it falls back to FetchContent in case the package is not found. This change also adopts the "CMake" dir name convention present everywhere in the code base (instead of the originally expected "cmake").
Contributor
|
Hi @dorileo, thanks for your suggestion. The team reviewed this and decided not to proceed at the moment as we believe we already have clear instructions in place describing how this works. If you feel there are specific issues that aren't being addressed, please open an issue on this repo and we'll take a look. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid frustration for newcomers and offer a last resort for resolving dependencies. The dependencies install script may fail in certain OSes or distributions, adding the find modules to template project improves the experience once it falls back to FetchContent in case the package is not found.
This change also adopts the "CMake" dir name convention present everywhere in the code base (instead of the originally expected "cmake").