Skip to content

Simulation configuration form#142

Draft
bnmajor wants to merge 2 commits into
save-simulation-configfrom
sim-config-form
Draft

Simulation configuration form#142
bnmajor wants to merge 2 commits into
save-simulation-configfrom
sim-config-form

Conversation

@bnmajor

@bnmajor bnmajor commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Two fixes to the PHOLD simulation config form:

  1. Validation errors were never shown to the user. The form would be submitted but then be silently re-rendered on failure with no indication that there was an error or what the error was.
  2. Field ranges weren't fully aligned with the actual PHOLD constraints
    1. lookahead had no upper bound
    2. There was no check that mean stayed greater than lookahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant