Refactor duplicated Plotly code#96
Merged
Merged
Conversation
marySalvi
force-pushed
the
js-modules
branch
2 times, most recently
from
April 22, 2026 15:44
e047187 to
ec5ddb3
Compare
bnmajor
force-pushed
the
refactor-plotly
branch
from
April 23, 2026 14:18
1bf57e7 to
910e1d2
Compare
bnmajor
marked this pull request as ready for review
April 23, 2026 14:26
bnmajor
marked this pull request as draft
April 27, 2026 15:19
bnmajor
force-pushed
the
refactor-plotly
branch
7 times, most recently
from
June 17, 2026 15:08
9e87227 to
552fe78
Compare
bnmajor
marked this pull request as ready for review
June 17, 2026 15:08
Create plotUtils.js with shared Plotly utilities
Collaborator
Author
marySalvi
reviewed
Jul 10, 2026
The local initPlot() method internally called the same-named imported initPlot() from plotUtils.js, overloading the identifier with two different meanings. Rename the shared utility to `setupPlot` to remove the ambiguity.
marySalvi
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #99
Closes #48