feat(tests): add tests for handling empty array plugin configurations - #2184
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2184 +/- ##
==========================================
+ Coverage 35.92% 35.96% +0.03%
==========================================
Files 82 82
Lines 7832 7832
==========================================
+ Hits 2814 2817 +3
+ Misses 4753 4751 -2
+ Partials 265 264 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…empty array plugin config
Prashansa-K
reviewed
Aug 11, 2026
VarunAthreya
commented
Aug 11, 2026
| // Test_Diff_EmptyArrayPluginConfig_OmittedFieldMatchesEmptyArray pins down that omitting an array field entirely | ||
| // is indistinguishable from setting it to [], since decK fills both sides with nil before comparing. | ||
| // | ||
| // NOTE: Deliberately NOT wrapped in runDualTestWithSkipDefaults, unlike the two tests above. That helper runs the same |
Member
Author
There was a problem hiding this comment.
@Prashansa-K reason for not adding dual test here
should we go ahead with this solution and create a issue to work on this edge case in future or address this now?
Prashansa-K
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add integration tests to verify decK correctly handles plugin configurations with explicitly empty arrays, preventing perpetual diffs that never converge. Tests cover various scenarios top-level and nested empty arrays, enterprise plugins, and string arrays. Also validates that genuine changes from empty to populated arrays are still detected, and that omitted fields match empty arrays.
An unintended side effect was discovered and has been documented here: #2188