Claude/add comprehensive logging 5ca kj#326
Merged
Merged
Conversation
Adds structured logging using the unified SPARK_LOG_* macro system across every major engine subsystem that previously lacked instrumentation. Coverage spans SparkEngine core, graphics, physics, networking, ECS, animation, audio, scripting, streaming, gameplay, editor panels/subsystems, all 7 game modules, and SparkConsole. Uses appropriate log levels (Trace through Fatal) and categories for each subsystem, with rate-limited and one-shot macros in hot paths to avoid performance impact. https://claude.ai/code/session_017S5DmcNixsaLYJD9VDtqk5
Contributor
❌ CI Error ReportFailed jobs: windows-vs2022-Release Test Failures
Compiler Warnings (15)Updated: 2026-03-30T20:38:13Z — this comment is updated in-place, not duplicated. |
Two issues: 1. SparkConsole CMakeLists.txt was mangled by clang-format (it's CMake, not C++) — revert all SparkConsole logging changes since it's a standalone app that doesn't link SparkEngineLib 2. ComponentReflection.cpp: pass field.name.c_str() instead of field.name to snprintf %s (Clang -Wnon-pod-varargs error) https://claude.ai/code/session_017S5DmcNixsaLYJD9VDtqk5
Same issue as line 128 — field.name is std::string, needs .c_str() for snprintf %s format specifier. https://claude.ai/code/session_017S5DmcNixsaLYJD9VDtqk5
Contributor
Code Coverage (GCC + lcov) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.