Add separate 'Simulating' play mode with UI controls and manager support#445
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df127c40f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Code Coverage (GCC + lcov)Per-Subsystem Coverage
Total: 50.8% (18263/35968 lines) |
Contributor
❌ CI Error ReportFailed jobs: windows-vs2022-Release Test Failures
Updated: 2026-04-10T00:18:46Z — this comment is updated in-place, not duplicated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
SimulatingtoPlayModeStateand introduceonEnterSimulate/onExitSimulatecallbacks inPlayModeCallbacksinPlayModeTypes.h.PlayModeManagerwithEnterSimulationMode,ToggleSimulationMode,IsSimulating, andm_wasSimulatingBeforePauseto preserve simulation-vs-play semantics across pauses and exits, and update console/status reporting.PlayModeManagerto correctly handle theSimulatingstate and invoke simulation callbacks where appropriate.PlayModeManagerinto panels after initialization inEditorPanelFactory.cppso dependent panels (e.g.PlayModeToolbar,DedicatedServer) receive the manager instance.EditorUI.*,PlayModeToolbarPanel.*,EditorMenuBar.cpp) to visualize and handle theSimulatingstate, add an F6 hotkey for toggling simulation, callm_playModeManager.Update(deltaTime)during the editor update loop, and adjust notifications and button styling accordingly.Testing
ctest, which completed successfully.tests/editor_integration) to verify play/simulate toggle behavior and UI updates, which all passed.Simulatingstate transitions and callbacks during automated runs, with no failures observed.Codex Task