Skip to content

Claude/stability validation pass a4a dc#448

Merged
Krilliac merged 4 commits into
Workingfrom
claude/stability-validation-pass-A4aDc
Apr 10, 2026
Merged

Claude/stability validation pass a4a dc#448
Krilliac merged 4 commits into
Workingfrom
claude/stability-validation-pass-A4aDc

Conversation

@Krilliac

Copy link
Copy Markdown
Owner

No description provided.

claude added 4 commits April 10, 2026 01:51
…atting

- Add RAII SpinlockGuard to GraphicsEngine draw list (prevents deadlock on exception)
- Add division-by-zero guard in DDGIProbeSystem::SphericalFibonacci
- Add null/bounds checks in MeshClusterSystem::BuildClusters (pointer + index validation)
- Add empty() guards before front() in UIDesignerSystem preset builders
- Add bounds-checked enum-to-array index in LoadingScreen::Console_GetStatus
- Add bounds validation in CommandPalette::ExecuteSelected (nested index check)
- Add try-catch for std::stoi in SparkEditor debugger detection (main.cpp)
- Add try-catch for std::stof in RPGGameplayBridge dialogue condition
- Add @file/@brief Doxygen to 3 Lifecycle headers (100% coverage restored)
- Apply clang-format to 7 files with minor style drift
- Update bloat baseline, docs, badges

Build: zero warnings. Tests: 4201/4202 pass (1 pre-existing networking test).

https://claude.ai/code/session_01BMiyGfHQyhpqRrVrNPmh13
- HLODSystem: guard cellEntities[0] with empty() check before access
- RenderGraph: bounds-check m_executionOrder index against m_passes.size()

https://claude.ai/code/session_01BMiyGfHQyhpqRrVrNPmh13
- PlatformInput::LoadFromConfig: wrap JSON key parsing loop in try-catch
- SubsystemConsoleCommandsExt: guard texture_budget console command
- DedicatedServerPanel: guard server address port parsing (fallback 27015)
- AdvancedAssetPipelineUI: guard metadata file TYPE/SIZE/STATUS parsing

All four parse external input (config files, user text, metadata files)
that can contain malformed numbers causing std::invalid_argument crashes.

https://claude.ai/code/session_01BMiyGfHQyhpqRrVrNPmh13
Sync CORE_METRICS snapshot with current index values:
345 test files, 4434 tests, ~519K LOC, 1602 source files.

https://claude.ai/code/session_01BMiyGfHQyhpqRrVrNPmh13
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage (GCC + lcov)

Utils/MemoryMonitor.h                          |85.7%    14| 0.0%  12|    -    0
Utils/MultiISA.h                               |42.9%    14| 0.0%   6|    -    0
Utils/NetworkHealthMonitor.cpp                 | 113%    15| 0.0%   2|    -    0
Utils/NetworkHealthMonitor.h                   |    -     0|    -   0|    -    0
Utils/OpaqueHandle.h                           | 282%    11| 0.0%  15|    -    0
Utils/ProcessLinux.cpp                         |16.5%   182| 0.0%  28|    -    0
Utils/Profiler.cpp                             |14.2%   113| 0.0%  15|    -    0
Utils/Profiler.h                               |36.4%    33| 0.0%  12|    -    0
Utils/RandomEngine.h                           |29.3%    41| 0.0%  12|    -    0
Utils/Result.h                                 | 100%    29| 0.0%  28|    -    0
Utils/RingBuffer.h                             | 108%    59| 0.0%  64|    -    0
Utils/ScopeGuard.h                             | 142%    36| 0.0%  51|    -    0
Utils/ScopedTimer.h                            |25.0%    12| 0.0%   3|    -    0
Utils/Serializer.h                             | 100%    48| 0.0%  42|    -    0
Utils/SparkConsole.cpp                         |28.5%   144| 0.0%  17|    -    0
Utils/SparkConsole.h                           | 100%     2| 0.0%   2|    -    0
Utils/SparkError.h                             |10.9%    55| 0.0%   6|    -    0
Utils/SplinePath.h                             |    -     0|    -   0|    -    0
Utils/StackTrace.h                             |10.8%    74| 0.0%   8|    -    0
Utils/StateMachine.h                           |54.0%    63| 0.0%  32|    -    0
Utils/StringUtils.h                            |18.1%   116| 0.0%  21|    -    0
Utils/Telemetry.h                              |20.7%   135| 0.0%  22|    -    0
Utils/ThreadDebugger.h                         |11.6%   199| 0.0%  23|    -    0
Utils/ThreadSafeQueue.h                        |27.5%    40| 0.0%  11|    -    0
Utils/TimerManager.h                           |19.8%    96| 0.0%  19|    -    0
Utils/UUID.h                                   |43.2%    37| 0.0%  16|    -    0
Utils/Validate.h                               |    -     0|    -   0|    -    0

[/home/runner/work/SparkEngine/SparkEngine/SparkSDK/Include/Spark/]
IEngineContext.h                               |7300%     1| 0.0%   1|    -    0
ServiceInterfaces.h                            | 200%     3| 0.0%   3|    -    0
Version.h                                      |    -     0|    -   0|    -    0
================================================================================
                                         Total:|29.2% 23750| 0.0%  4k|    -    0

Per-Subsystem Coverage

Subsystem Lines Hit Coverage Threshold Status
AI 2776 694 25% 35%
Animation 160 154 96.2% 35%
Audio 0 0 0% 30%
Camera 0 0 0% 40%
Core 2248 1394 62% 40%
ECS 190 114 60% 40%
Editor 6084 1864 30.6% 25%
GameModules 6244 3144 50.4% 30%
Graphics 7203 3795 52.7% 30%
Networking 3379 2247 66.5% 35%
Physics 0 0 0% 35%
Scripting 0 0 0% 30%
Utils 7687 4865 63.3% 60%

Total: 50.8% (18271/35971 lines)

@github-actions

Copy link
Copy Markdown
Contributor

❌ CI Error Report

Failed jobs: windows-vs2022-Release
Errors: 0 | Test failures: 3 | Warnings: 0

Test Failures

Test Jobs
1/1 Test #1: SparkEngineTests .................***Failed 12.49 sec windows-vs2022-Release
[ FAILED ] Integration_NetworkingECS_ReplicationLatencyJitterPredictionReconciliation (536us, 8 assertions) windows-vs2022-Release
0% tests passed, 1 tests failed out of 1 windows-vs2022-Release

Updated: 2026-04-10T02:33:33Z — this comment is updated in-place, not duplicated.

@Krilliac
Krilliac merged commit d4de1f0 into Working Apr 10, 2026
24 of 25 checks passed
@Krilliac
Krilliac deleted the claude/stability-validation-pass-A4aDc branch April 10, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants