[bot] Fast-forward for 26.3.16#961
Merged
Merged
Conversation
…nterface (#954) Fixes two bugs on the Animal Groups data-entry form (animalGroupCategories): 1. "Update failed: Unable to convert value 'null' to Integer" when saving a row with a blank Sort Order - AnimalGroupsController.UpdateGroupsAction was passing the JSON null sentinel straight to the row map. Guarded sort_order with o.isNull("sortOrder") so a blank field is sent as a real SQL null (the column is nullable). 2. Start/End date drifting back one day on every edit (timezone round-trip) This needed a coordinated server + client change; neither half fixes it alone: - Server (AnimalGroup.toJSON): format date and endDate with DateUtil.formatIsoDate(...) so the payload carries a bare Y-m-d string instead of a zoned datetime. - Client (AnimalGroupsStore.js): added dateReadFormat: 'Y-m-d' to the date and endDate fields so ExtJS parses that string as a local date rather than UTC midnight (which shifted it to the prior day in Central time).
#### Rationale Package updates for client-side application. #### Changes - Update all packages to latest - Mark as `private` as this is not a published npm package #### Tasks - [x] Manual testing @labkey-martyp - [x] Client verification Co-authored-by: Marty Pradere <martyp@labkey.com>
* createSNDCategories now selects existing rows from snd.PkgCategories first * populateInitialData builds its populateData action URL instead of concatenating with a literal path.
cnathe
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated automatically.
Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
View all PRs: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=26.3_ff_bot_26.3.16