Install public headers; de-duplicate install include dir#1
Merged
Conversation
added 2 commits
July 4, 2026 16:51
An installed libnyquist shipped its static lib and CMake config but never installed its headers (the "todo, install the headers" note), so find_package(libnyquist) succeeded yet the imported target's include dir (<prefix>/include) contained no headers. Downstream projects that build against an installed libnyquist could not compile. - install(DIRECTORY include/libnyquist ...) so <prefix>/include/libnyquist holds the public headers, matching $<INSTALL_INTERFACE:include>. - Drop the redundant INCLUDES DESTINATION on install(TARGETS): the install interface include dir is already declared via $<INSTALL_INTERFACE:include> in target_include_directories(), so it was landing in INTERFACE_INCLUDE_DIRECTORIES twice. Verified: fresh configure/build/install now populates include/libnyquist and lists <prefix>/include exactly once in the generated config.
RtApi::byteSwapBuffer used `register char val; register char *ptr;`. The register storage-class specifier was removed in C++17, so modern clang/gcc reject it (error: ISO C++17 does not allow 'register' ... [-Wregister]), breaking the libnyquist-examples build in CI on Linux/macOS. The keyword is a no-op hint on every compiler since C++11; drop it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An installed libnyquist shipped its static lib and CMake config but never installed its headers (the "todo, install the headers" note), so find_package(libnyquist) succeeded yet the imported target's include dir (/include) contained no headers. Downstream projects that build against an installed libnyquist could not compile.
Verified: fresh configure/build/install now populates include/libnyquist and lists /include exactly once in the generated config.