fix: cap transaction page size - #1407
Open
silentgeckoaudit3801 wants to merge 3 commits into
Open
Conversation
ogazboiz
requested changes
Aug 3, 2026
ogazboiz
left a comment
Contributor
There was a problem hiding this comment.
the fix itself is right, MAX_LIMIT 500 to 50 matches the issue and the Math.min path is verified. one tiny thing now blocks it: CI lint fails with a missing trailing newline in backend/src/controllers/tests/transactionControllerLimits.test.ts (prettier "Insert newline" at 12:4). run:
cd backend && npx prettier --write src/controllers/__tests__/transactionControllerLimits.test.ts && git commit -am "chore: prettier" && git push
and this merges.
if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_LIMITfrom 500 to 50Fixes #1335.
Validation