fix: roundToCents uses Math.round instead of Math.floor to round to n… - #1453
Closed
jotel-dev wants to merge 1 commit into
Closed
fix: roundToCents uses Math.round instead of Math.floor to round to n…#1453jotel-dev wants to merge 1 commit into
jotel-dev wants to merge 1 commit into
Conversation
ogazboiz
requested changes
Aug 3, 2026
ogazboiz
left a comment
ogazboiz
left a comment
Contributor
There was a problem hiding this comment.
right diagnosis, Math.floor always rounding down is a real bug. but the repo money policy (backend/src/money/policy.generated.ts) specifies half_even rounding, and Math.round is half-up (and asymmetric for negatives), so this fix trades one policy violation for another. the money-policy CI job only checks artifact drift, which is why it stays green.
- round via the half-even helper in backend/src/money/decimal.ts (or equivalent) instead of Math.round.
- add a unit test covering the .5 cases (e.g. 0.125 -> 0.12 and 0.135 -> 0.14).
if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.