Call github action docker/github-builder with the necessary build arguments#216
Merged
Conversation
JohnVillalovos
approved these changes
Jul 16, 2026
Collaborator
There was a problem hiding this comment.
Thanks @colisee LGTM. Though I would prefer if the commit message (and the PR message) were more informative.
If we ever stopped using GitHub then having a commit message of "Fix issue 215" won't be that informative. Or if you are somewhere without Internet access.
docker/github-builder with the necessary build arguments
Collaborator
Author
|
I am afraid I can no longer change the commit message since it is published, unless you know how to do it. I changed the PR message though |
Collaborator
This should work: |
ikke-t
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build arguments
APP_GH_REFandAPP_GH_ADD_SHAwere not passed to github actiondocker/github-builderFix issue #215