Skip to content

Call github action docker/github-builder with the necessary build arguments#216

Merged
colisee merged 2 commits into
LibreBooking:masterfrom
colisee:issues/215
Jul 17, 2026
Merged

Call github action docker/github-builder with the necessary build arguments#216
colisee merged 2 commits into
LibreBooking:masterfrom
colisee:issues/215

Conversation

@colisee

@colisee colisee commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Build arguments APP_GH_REF and APP_GH_ADD_SHA were not passed to github action docker/github-builder

Fix issue #215

@colisee
colisee requested a review from ikke-t July 16, 2026 15:51
@colisee colisee added the bug Something isn't working label Jul 16, 2026

@JohnVillalovos JohnVillalovos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @colisee LGTM. Though I would prefer if the commit message (and the PR message) were more informative.

If we ever stopped using GitHub then having a commit message of "Fix issue 215" won't be that informative. Or if you are somewhere without Internet access.

@colisee colisee changed the title Fix issue 215 (missing build arguments) Call github action docker/github-builder with the necessary build arguments Jul 16, 2026
@colisee

colisee commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

I am afraid I can no longer change the commit message since it is published, unless you know how to do it. I changed the PR message though

@JohnVillalovos

Copy link
Copy Markdown
Collaborator

I am afraid I can no longer change the commit message since it is published, unless you know how to do it. I changed the PR message though

This should work:

$ git commit --amend
$ git push --force-with-lease

@colisee
colisee merged commit b14ab42 into LibreBooking:master Jul 17, 2026
3 checks passed
@colisee
colisee deleted the issues/215 branch July 17, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants