Fix OAuth client registration metadata - #36
Merged
Conversation
tiankaima
marked this pull request as ready for review
August 11, 2026 14:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The registration provider defaults clients without
application_typeto web clients. It then rejects the CLI's HTTP loopback callback, even though loopback HTTP redirects are valid for native clients. The device flow also sent a placeholder callback despite not using redirects.Impact
life-ustc account logincan register its ephemeral loopback callback, andlife-ustc account login --deviceregisters as a redirect-free device client.Validation
go test ./...go test -race ./...go vet ./...golangci-lint run ./...go build -buildvcs=false -ldflags "-X github.com/Life-USTC/CLI/internal/cmd/root.version=dev" -o life-ustc ./cmd/life-ustcThe normal
make buildreached the Go build step but Go 1.25 VCS stamping failed in the linked worktree while probing/home/tiankaima; the equivalent build with VCS stamping disabled passed.