Mollusk 0.14 - #1
Conversation
- Bump mollusk-svm 0.3.0 -> 0.14.0 and solana-program-runtime 2.3 -> 4.1 - Pin solana-hash =4.5.0 to keep wincode 0.5 aligned across the agave 4.1 graph - Use public ProgramCache::register_builtin_function instead of private field access - Use built-in solana_program_runtime::memory::translate_slice - Adapt declare_builtin_function! to the 5-arg InvokeContext<'static, 'static> API - Update test-program dev-deps and doctest for the new add_program signature
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8afb60d668
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| func_name, | ||
| file_location, | ||
| total_cu: entry.total_cu, | ||
| net_cu: entry.net_cu, |
There was a problem hiding this comment.
When the Mollusk helper is used on nested profiled calls deeper than one level, post_process() subtracts every descendant from each parent even though a direct child's total_cu already includes its own children. Exposing that value here as ProfileEntry.net_cu makes the new report understate parent Net CU (often clamping it to zero), so benchmark reports become inaccurate for nested #[profile] sections.
Useful? React with 👍 / 👎.
| .into_iter() | ||
| .enumerate() | ||
| .map(|(i, name)| { | ||
| let anchor = name.to_lowercase().replace([' ', '_'], "-"); |
There was a problem hiding this comment.
Every section is rendered as ## {i}. {display_name}, but the TOC anchor is built only from the raw section name. For a section named sync_transfer, this emits a link to #sync-transfer while the generated heading slug includes the numeric prefix (for example #1-sync-transfer), and display-name overrides make the mismatch worse; generated reports therefore have broken Table of Contents links.
Useful? React with 👍 / 👎.
f426a03 to
8afb60d
Compare
1 participant
No description provided.