fix: issue with aoe subteams with team participants - #7448
Conversation
63af91c to
2e3520a
Compare
There was a problem hiding this comment.
Pull request overview
Fixes missing team roster/flag variable storage for subteam (A/B variant) participants by ensuring the team’s template identifier is included among the stored aliases, improving downstream retrieval in match parsing/display.
Changes:
- Add
opponent.templateto the alias list generated for each parsed team participant. - This results in additional alias-based variable storage paths for teams, helping match modules find roster/flag data for subteams.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| local function generateObjectName() | ||
| local team = Opponent.toName(participant.opponent) | ||
| local team = TeamTemplate.getPageNameNoRedirect(participant.opponent.template) |
There was a problem hiding this comment.
Todo: Redirect or not needs to be toggled as *craft wikis have it enabled in PrizePool
There was a problem hiding this comment.
Can't we drop it from PPT on craft wikis?
There was a problem hiding this comment.
would need to check the earnings etc stuff on sc2 in player/team infoboxes
if that relies on the redirect it would need to be adjusted first
could also potentially break
- https://liquipedia.net/starcraft2/Module:Tournament_statistics_teams_lpdb
- https://liquipedia.net/starcraft2/Module:Team_top_results
- https://liquipedia.net/starcraft2/Module:TeamResultTimeLine
currently don't have the time to check it
There was a problem hiding this comment.
Why would these require the object name to not have a redirect?
Summary
Resolves #7217
How did you test this change?
dev