Skip to content

feat(PrizePool): Placement Badges for W/L/DQ - #7821

Open
hjpalpha wants to merge 17 commits into
mainfrom
w-l-dq-placement-badges
Open

feat(PrizePool): Placement Badges for W/L/DQ#7821
hjpalpha wants to merge 17 commits into
mainfrom
w-l-dq-placement-badges

Conversation

@hjpalpha

Copy link
Copy Markdown
Collaborator

Summary

as per discussion in discord: https://discord.com/channels/93055209017729024/1523680790716616794/1523680790716616794

  • fix L-Placement rows to have a bg on the entire row
  • add placement badge support for W/L/DQ

How did you test this change?

dev + dev tools

Before:
image
image

After:
image
image

@hjpalpha
hjpalpha marked this pull request as ready for review July 15, 2026 12:23
@hjpalpha
hjpalpha requested review from a team as code owners July 15, 2026 12:23
@mbergen

mbergen commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Should we get rid of the abbreviation on DQ?

@PiddyNydra

Copy link
Copy Markdown

Should we get rid of the abbreviation on DQ?

yeah i think we can

doubt there's any esport/sport fan that wouldnt know what a "DQ" is

@mbergen

mbergen commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

yeah i think we can

doubt there's any esport/sport fan that wouldnt know what a "DQ" is

What about the other special placements that use abbreviation tags?

Namely:

  • DNF ("Did not finish")
  • DNP ("Did not participate")
  • Q ("Qualified Automatically") (n.b.: What is this?!)

@mbergen

mbergen commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Also, @hjpalpha: Would you mind adding the ppt from your example screenshot as GoldenTest?

@hjpalpha

Copy link
Copy Markdown
Collaborator Author

Also, @hjpalpha: Would you mind adding the ppt from your example screenshot as GoldenTest?

i am super busy today
feel free to add it
else i will have to look into it in the next days

Comment thread lua/wikis/commons/PrizePool/Placement.lua Outdated
@hjpalpha
hjpalpha requested a review from mbergen August 7, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants