feat(Infobox): add new params to brawlstars Infobox/Unit - #7861
Open
PolandBot wants to merge 12 commits into
Open
feat(Infobox): add new params to brawlstars Infobox/Unit#7861PolandBot wants to merge 12 commits into
PolandBot wants to merge 12 commits into
Conversation
Update infobox for brawlers to support bunch new params
hjpalpha
reviewed
Jul 27, 2026
Collaborator
There was a problem hiding this comment.
does it all have to be in infobox?
infoboxes are way too big already ...
Contributor
Author
There was a problem hiding this comment.
I think yes, like it's not the biggest infobox I've seen at all
Contributor
There was a problem hiding this comment.
Imo should be fine though, it's having quite same height as #mobilelegends infobox
Collaborator
There was a problem hiding this comment.
tend to agree with hjp
not a good reason to make it even larger
Contributor
Author
There was a problem hiding this comment.
It will be quite the same with MLBB and LoL
hjpalpha
reviewed
Jul 27, 2026
Collaborator
There was a problem hiding this comment.
tend to agree with hjp
not a good reason to make it even larger
Comment on lines
+101
to
+107
| for voiceActorKey, voiceActor in Table.iter.pairsByPrefix(args, 'voice', {requireIndex = false}) do | ||
| local flag = args[voiceActorKey .. 'flag'] | ||
| if flag then | ||
| voiceActor = Flags.Icon{flag = flag} .. ' ' .. voiceActor | ||
| end | ||
| table.insert(voiceActors, voiceActor) | ||
| end |
Contributor
Author
There was a problem hiding this comment.
I tried to add this but not sure if it works clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We want to fully rework Brawler pages since more new countributors care about keeping this pages updated and actual. Now infobox supports many new params. (I looked at MLBB pages)
In total added support for:
Class
|class=Rarity
|rarity=Voice Actor(s) + flag(s)
|voiceX=|voiceXflag=Price
|price=Win Rate (Fully automatic)
Traits
|trait=Buffies
|buffies=How did you test this change?
dev
https://liquipedia.net/brawlstars/Byron - for all params and Esports Statistics
https://liquipedia.net/brawlstars/Module:BrawlerWinLoss
https://liquipedia.net/brawlstars/Brawl_Stars_Championship/2026/Chinese_Mainland/Finals - for new LPDB map extradata