ci: report the LuaLS problem count LuaLS actually reports - #7877
Open
Rathoz wants to merge 3 commits into
Open
Conversation
The step summary counted lines containing "Warning":
$(cat luals-check | grep 'Warning' | wc -l)
That gives 263 where LuaLS itself reports 238, because a single diagnostic can
span several lines. Use the totals LuaLS prints, and add files-with-problems
alongside them.
No delta is reported against the base, because the count is not deterministic:
237-240 across 8 runs on identical code, in both pretty and json output, with no
--threads flag to pin the analysis. Files-with-problems was stable at 142 in
every run, so that is the number worth watching, and the summary says as much.
Gating behaviour is untouched; only the summary lines change.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Rathoz
added a commit
that referenced
this pull request
Jul 29, 2026
Two unrelated changes were sharing a branch: a new metric and a fix to an existing one. Split so they can be reviewed and reverted independently. The LuaLS summary fix now lives in #7877. luals-code-style here is byte identical to main again; this branch only adds annotation coverage. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
luals-code-stylestep summary counted lines containingWarning, which overcounts — a single diagnostic can span several lines.No delta vs the base branch, because the count isn't deterministic — 237–240 across 8 runs on identical code, in both
prettyandjsonoutput, and there's no--threadsflag to pin it. Files-with-problems was stable at 142 every run, so that's the number to watch. The summary says so inline.Split out of #7863, which keeps the annotation coverage metric.
How it was tested
lua/wikis/**/*.luachanges, so a one-byte commons change was needed to trigger it. Reported1710 / 142 / 238, matching local measurement on a different OS/arch.--check_format=jsonoutput (142 files both ways)