Skip to content

Extend displaying remaining lifetime from 24 to 48 hrs #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dnzxy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Extend displaying remaining lifetime from 24 to 48 hrs #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd433f7
Extend displaying remaining lifetime from 24 to 48 hrs
dnzxy Jun 28, 2026
6f86bb3
Reserve .warning for <24h band
dnzxy Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions G7SensorKitUI/G7CGMManager/G7CGMManager+UI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,15 @@ extension G7CGMManager: CGMManagerUI {
public var cgmLifecycleProgress: DeviceLifecycleProgress? {
switch lifecycleState {
case .ok:
// show remaining lifetime, if < 24 hours
// show remaining lifetime, if < 48 hours
guard let expiration = sensorExpiresAt else {
return nil
}
let remaining = max(0, expiration.timeIntervalSinceNow)

if remaining < .hours(24) {
return G7LifecycleProgress(percentComplete: 1-(remaining/lifetime), progressState: .warning)
if remaining < .hours(48) {

@ps2 ps2 Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is starting to show warning state at 48 hours. I think it's fine showing the progress bar earlier, but it should probably still be non-warning, until 24 hours before.

@dnzxy dnzxy Jun 29, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapted in 6f86bb3

let progressState: DeviceLifecycleProgressState = remaining < .hours(24) ? .warning : .normalCGM
return G7LifecycleProgress(percentComplete: 1-(remaining/lifetime), progressState: progressState)
}
return nil
case .gracePeriod:
Expand Down