sd: support for checking or aborting the current generation#2316
Draft
wbruna wants to merge 2 commits into
Draft
sd: support for checking or aborting the current generation#2316wbruna wants to merge 2 commits into
wbruna wants to merge 2 commits into
Conversation
Author
|
I've split the dropped connection handling to #2318 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow checking the state of the current gen (current step, image preview), and aborting it.
This is just a POC of the C++ support for now. I've added a temporary URL to test the image preview (deliberately ignoring
lastgeneratedcachedimgkeyjust to make it easier to test).