feat: support RetroArch's new cheat format (#795) - #798
Open
carroarmato0 wants to merge 1 commit into
Open
Conversation
libretro-database's FBNeo cheats put the count last and quoted, and describe a memory write instead of a code string, so parsing failed and the cheats menu showed "No cheat file loaded". Read the count from anywhere in the file, accept quoted values, and apply memory-write cheats each frame. Also fixes Cheats_load returning an undefined value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libretro-database's FBNeo cheats put the count last and quoted, and describe a memory write instead of a code string, so parsing failed and the cheats menu showed "No cheat file loaded".
Read the count from anywhere in the file, accept quoted values, and apply memory-write cheats each frame. Also fixes Cheats_load returning an undefined value.
Tested this against the game and cheat table used when submitting: #795
The cheats are correctly loaded in the new format an verified to work.
Backwards compatibility also tested with a random other game using the same old format.