fix(mh3g): preserve companion mask mastery state - #41
Closed
VincentAdamNemessisX wants to merge 1 commit into
Closed
fix(mh3g): preserve companion mask mastery state#41VincentAdamNemessisX wants to merge 1 commit into
VincentAdamNemessisX wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #44. The mask/mastery fix is preserved there with the same stable patch-id, together with the paired-transfer Hunter's Notes correction and Windows repair-flow regression fix. Closing this standalone PR avoids a duplicate auto-release; attribution is retained in the cherry-picked commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
u32prefix plusu16scalars, instead of threeu32header fields0xDE..0x140, including the historically mis-swapped pair at0xE4Root cause
The previous Lamp Mask fix inferred that companion-relative
0xE4was an isolated endian-sensitiveu16. Five paired 3DS -> Wii U transfer samples disprove that assumption:0xDE..0x140is byte-packed and remains identical on both platforms. The old transform changed values such as18 00into00 18, so the companion status path observed a leading zero; quest serialization could then write zero back into the mask state.The same paired samples also show that relative
0x04..0x0Bconsists of fouru16values, not twou32values.Evidence
cargo test -p mh3g-save-convert: 220 passedx86_64-pc-windows-msvcclippy with-D warnings: passed0262a4c5353deca35fa1220d89c87414383bab1454509d06d14d6414f78277120x000..0x13Fcompanion schema; packed0xDE..0x13Fequals the 3DS source in all ten recordsa1815a838bbe45cf33fc6db41efc4d5b438b53d7f6bc7d1704b78d56879b562c), and rollback removed the separate output successfullyValidation boundary
00 00conflict is preserved fail-closed; forcing recovery requires a paired before/after snapshot rather than guessing over later Wii U progress