IN 1791 - Disable row count integrity checks - #213
Merged
Conversation
Why these changes are being introduced: After disabling the integrity check for `Employee Appointments` that ensures we don't have more rows in Quickbase than the data warehouse, which was preventing the updating of data, we are seeing this again for another table `Employee Salary History`. After some analysis, the issue appears begign. It would seem that sometimes data that once came through in the data warehouse, is not found in later runs (e.g. pre-library appointments for employees who have left the library, end of leave when correlated with a position change). They are uniformly edge cases. It has been determined that keeping the data in Quickbase which we did accurately capture once is more valuable, at this time, then deleting data to satisfy these integrity checks as-is. That said, these checks theoretically would unrelated bugs and regressions. How this addresses that need: At this time, the decision is to disable these simple row count integrity checks, but keep them in code if we elect to revisit them later. Side effects of this change: * Data may accumulate in Quickbase that is no longer available from the data warehouse; often desirable, though sometimes indicates an error or bug. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/IN-1791
ghukill
marked this pull request as ready for review
July 27, 2026 19:15
jonavellecuerdo
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Why these changes are being introduced:
After disabling the integrity check for
Employee Appointmentsthat ensures we don't have more rows in Quickbase than the data warehouse (#212), which was preventing the updating of data, we are seeing this again for another tableEmployee Salary History.After some analysis, the issue appears benign. It would seem that sometimes data that once came through in the data warehouse, is not found in later runs (e.g. pre-library appointments for employees who have left the library, end of leave when correlated with a position change). They are uniformly edge cases.
It has been determined that keeping the data in Quickbase which we did accurately capture once is more valuable, at this time, then deleting data to satisfy these integrity checks as-is. That said, these checks theoretically would catch unrelated bugs and regressions.
How this addresses that need:
At this time, the decision is to disable these simple row count integrity checks, but keep them in code if we elect to revisit them later.
Includes new or updated dependencies?
NO
Changes expectations for external applications?
YES: Data may accumulate in Quickbase that is no longer available from the data warehouse; often desirable, though sometimes indicates an error or bug.
What are the relevant tickets?