Conversation
Why these changes are being introduced: Thesis and Hold Source are required fields on the Hold model. This is defined in the db schema, but not at the model layer. Because administrate checks model validations to identify required fields, this means that these fields don't appear as required in the admin forms. Relevant ticket(s): - [ETD-691](https://mitlibraries.atlassian.net/browse/ETD-691) How this addresses that need: This adds validations for Thesis and Hold Source to the Hold model. Side effects of this change: None.
|
coverage: 98.25%. remained the same — etd-691 into main |
JPrevost
requested changes
Jul 29, 2026
JPrevost
left a comment
JPrevost
left a comment
Member
There was a problem hiding this comment.
Would you mind adding tests around a hold being invalid without a hold_source and without a thesis? I'm thinking mostly in case someone changes this in the future those tests should fail.
Why these changes are being introduced: The report summary table is extremely inefficient and probably not very useful. Relevant ticket(s): - [ETD-623](https://mitlibraries.atlassian.net/browse/ETD-623) How this addresses that need: This removes the summary table, so the report index view just lists links to the individual reports. Side effects of this change: - Link sidebar has been removed from the dashboard, as it is now redundant. - The report dashboard is now a visual design abomination, but that feels better than a million N+1 queries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
Thesis and Hold Source are required fields on the
Hold model. This is defined in the db schema, but
not at the model layer.
Because administrate checks model validations to
identify required fields, this means that these
fields don't appear as required in the admin
forms.
Relevant ticket(s):
How this addresses that need:
This adds validations for Thesis and Hold Source
to the Hold model.
Side effects of this change:
None.
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO