Skip to content

Optimize ACC port of atm_compute_solve_diagnostics_work:7418 #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abishekg7 wants to merge 2 commits into
base: develop
Choose a base branch
from
+5 −6
Open

Optimize ACC port of atm_compute_solve_diagnostics_work:7418 #1484

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5b1e01
Add timers
abishekg7 Jul 6, 2026
5368541
Opt 1 - move r1 and r2 to inner loop and collapse loops
abishekg7 Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/core_atmosphere/dynamics/mpas_atm_time_integration.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7399,7 +7399,7 @@ subroutine atm_compute_solve_diagnostics_work(nCells, nEdges, nVertices, &


!$OMP BARRIER

call mpas_timer_start('atm_compute_solve_diag_7418')
!
! Modify PV edge with upstream bias.
!
Expand All @@ -7416,20 +7416,19 @@ subroutine atm_compute_solve_diagnostics_work(nCells, nEdges, nVertices, &
!
r = config_apvm_upwinding * dt
!$acc parallel default(present)
!$acc loop gang
!$acc loop gang worker vector collapse(2)
do iEdge = edgeStart,edgeEnd
r1 = 1.0_RKIND * invDvEdge(iEdge)
r2 = 1.0_RKIND * invDcEdge(iEdge)
!DIR$ IVDEP
!$acc loop vector
do k = 1,nVertLevels
r1 = 1.0_RKIND * invDvEdge(iEdge)
r2 = 1.0_RKIND * invDcEdge(iEdge)
gradPVt(k,iEdge) = (pv_vertex(k,verticesOnEdge(2,iEdge)) - pv_vertex(k,verticesOnEdge(1,iEdge))) * r1
gradPVn(k,iEdge) = (pv_cell(k,cellsOnEdge(2,iEdge)) - pv_cell(k,cellsOnEdge(1,iEdge))) * r2
pv_edge(k,iEdge) = pv_edge(k,iEdge) - r * (v(k,iEdge) * gradPVt(k,iEdge) + u(k,iEdge) * gradPVn(k,iEdge))
end do
end do
!$acc end parallel

call mpas_timer_stop('atm_compute_solve_diag_7418')

end if ! apvm upwinding

Expand Down