Replaced problematic incomplete gamma function with modernized version from SLATEC (copyright free).#1486
Open
robertmullis wants to merge 1 commit into
Open
Conversation
…n from SLATEC (copyright free)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix to replace the legacy incomplete gamma function with a modernized version from the SLATEC library, which is in the public domain. This also replaces the problematic log gamma function with the LOG_GAMMA Fortran intrinsic. Unit testing was performed on the function by compiling the source file against stand-in framework modules and comparing a series of values between the new and original implementations.
The implementations had a maximum relative difference of 4.1e-7, and the new implementation had a greater accuracy when compared to the Wolfram Alpha result for the same inputs (~1e-14 relative).
The functions were removed outright from
[src/core_atmosphere/physics/physics_wrf/module_mp_thompson.F]because they were legacy code that was not called anywhere else.