Skip to content

Custom Item Option - #76

Merged
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom
Zintixx:fixes3
Aug 1, 2026
Merged

Custom Item Option#76
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom
Zintixx:fixes3

Conversation

@Zintixx

@Zintixx Zintixx commented Aug 1, 2026

Copy link
Copy Markdown

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Bug Fixes

    • Added support for loading KMS2Merge item option constants, improving item option parsing.
  • Chores

    • Updated the project package version to 2.4.19.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The parser now includes the kms2merge item-option constant file. The project package version increases from 2.4.18 to 2.4.19.

Changes

Item option constant parsing

Layer / File(s) Summary
Parser suffix and package release
Maple2.File.Parser/ItemOptionParser.cs, Maple2.File.Parser/Maple2.File.Parser.csproj
ParseConstant() now includes the kms2merge constant file. The package version is updated to 2.4.19.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: angelotadeucci

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change, which adds support for a custom item option constant.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Maple2.File.Parser/ItemOptionParser.cs`:
- Line 22: Remove the untracked "kms2merge" suffix from the constant-name list
used by ParseConstant in ItemOptionParser, so it no longer requests the missing
itemoptionconstant_kms2merge.xml entry. Preserve all other supported suffixes
and existing parsing behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cc23c4b5-0afb-48b8-b3b4-58bd29fab741

📥 Commits

Reviewing files that changed from the base of the PR and between 8d65e29 and 5af9a96.

📒 Files selected for processing (2)
  • Maple2.File.Parser/ItemOptionParser.cs
  • Maple2.File.Parser/Maple2.File.Parser.csproj

Comment thread Maple2.File.Parser/ItemOptionParser.cs
@AngeloTadeucci
AngeloTadeucci merged commit 5303eb8 into MS2Community:master Aug 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants