MDEV-31554 Cursor protocol cuts off json boolean#5287
Open
grooverdan wants to merge 1 commit into
Open
Conversation
grooverdan
added
the
MariaDB Foundation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables cursor protocol tests in func_json.test and increases the length parameter from 1 to 5 in one of the Item_bool constructors in sql/item.h to prevent truncation. The reviewer recommends updating the other Item_bool constructors to consistently use a length of 5 to avoid similar truncation issues when those constructors are used.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
In Item_func_json_array_append::fix_length_and_dec,
Item_bool::max_char_length() was being used to
calculate the length that is required to fit a boolean.
Previously it was returning 1, which doesn't fit
"false".
Change Item_bool to return strlen("false"), 5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Item_func_json_array_append::fix_length_and_dec, Item_bool::max_char_length() was being used to
calculate the length that is required to fit a boolean.
Previously it was returning 1, which doesn't fit "false".
Change Item_bool to return strlen("false"), 5.