MDEV-37187 hashicorp plugin: avoid expensive clock() in hot path#5296
Open
vaintroub wants to merge 1 commit into
Open
MDEV-37187 hashicorp plugin: avoid expensive clock() in hot path#5296vaintroub wants to merge 1 commit into
vaintroub wants to merge 1 commit into
Conversation
The plugin used clock() only to timestamp cache entries and measure elapsed time against millisecond timeouts. As shown in MDEV-12345, clock() is prohibitively expensive, and we do not need per-thread or per-process CPU time here, only time differences. Replace clock()/clock_t with the monotonic std::chrono::steady_clock. Timeouts are kept as std::chrono::milliseconds
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the HashiCorp Key Management plugin to use std::chrono::steady_clock instead of clock_t and clock() for tracking cache timeouts and timestamps, ensuring monotonic and accurate real-time measurements. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin used clock() only to timestamp cache entries and measure elapsed time against millisecond timeouts. As shown in MDEV-12345, clock() is prohibitively expensive, and we do not need per-thread or per-process CPU time here, only time differences.
Replace clock()/clock_t with the monotonic std::chrono::steady_clock. Timeouts are kept as std::chrono::milliseconds