bugfix: random assignment after grader filtering#8073
Merged
david-yz-liu merged 3 commits intoJul 23, 2026
Merged
Conversation
Collaborator
Coverage Report for CI Build 29963842412Coverage increased (+0.001%) to 90.415%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
david-yz-liu
approved these changes
Jul 23, 2026
david-yz-liu
left a comment
Collaborator
There was a problem hiding this comment.
Nice work, @YheChen!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Ensure random grader assignment uses only the TA IDs accepted by
Grouping.assign_tas.Previously,
randomly_assign_tascalculated assignment counts from the original submitted IDs and ignored the filtered TA IDs yielded byassign_tas. A filtered-out role, such as a student, could therefore be reintroduced into the generated membership pairs. Its requested weight also remained part of the workload calculation.This PR:
assign_tasfilters the IDs;Valid random-assignment requests retain the existing relative weighting behavior. This is a focused follow-up to the review discussion in #8060 and is independent of #8072.
Screenshots of your changes (if applicable)
Type of Change
Checklist
Before opening this pull request:
After opening this pull request:
Questions and Comments