Skip to content

Decreased scanned exam QR code size and ignored OCR whitespace characters#8076

Merged
david-yz-liu merged 1 commit into
masterfrom
scan-code-improvements
Jul 23, 2026
Merged

Decreased scanned exam QR code size and ignored OCR whitespace characters#8076
david-yz-liu merged 1 commit into
masterfrom
scan-code-improvements

Conversation

@david-yz-liu

@david-yz-liu david-yz-liu commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

This PR decreases the scanned assessment QR code size by 25%, now down to a 1-inch square. It fixes a bug where sometimes the tesseract OCR inserted spaces, e.g. "midterm 1" instead of "midterm1"; these spaces are now removed when handling the OCR output, as the generated text labels cannot contain spaces.

It also updates our tests to assert exact scanned page numbers rather than a simple complete/incomplete paper check.

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
📖 Documentation update (change that updates documentation)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls

coveralls commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 30015010456

Coverage increased (+0.003%) to 90.433%

Details

  • Coverage increased (+0.003%) from the base build.
  • Patch coverage: 25 of 25 lines across 3 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 51392
Covered Lines: 47491
Line Coverage: 92.41%
Relevant Branches: 2470
Covered Branches: 1218
Branch Coverage: 49.31%
Branches in Coverage %: Yes
Coverage Strength: 127.84 hits per line

💛 - Coveralls

@david-yz-liu
david-yz-liu force-pushed the scan-code-improvements branch from 9584ef1 to 492626a Compare July 23, 2026 13:04
@david-yz-liu
david-yz-liu force-pushed the scan-code-improvements branch from 492626a to 1b75e97 Compare July 23, 2026 14:16
@david-yz-liu
david-yz-liu merged commit ee5226d into master Jul 23, 2026
12 checks passed
@david-yz-liu david-yz-liu added this to the v2.10.2 milestone Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants