compute: reduce boilerplate in linear join rendering#22563
Merged
Conversation
teskje
marked this pull request as ready for review
October 22, 2023 09:44
5 tasks
teskje
force-pushed
the
reduce-join-boilerplate
branch
from
October 22, 2023 09:48
957b326 to
3e8e9c7
Compare
This commit reduces the amount of boilerplate code in linear join rendering in two ways: * It replaces the four `dispatch_` functions with a single macro. * It makes `differential_join` and `differential_join_inner` methods of `Context`, to reduce the number of arguments that need to be passed around.
teskje
force-pushed
the
reduce-join-boilerplate
branch
from
October 23, 2023 10:19
3e8e9c7 to
ed684d0
Compare
antiguru
approved these changes
Oct 23, 2023
Contributor
Author
|
TFTRs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces the amount of boilerplate code in linear join rendering in two ways:
dispatch_functions with a single macro.differential_joinanddifferential_join_innermethods ofContext, to reduce the number of arguments that need to be passed around.Motivation
Tips for reviewer
The diff looks much better with whitespace ignored!
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.