Handle CR line endings in the query editor - #293
Draft
bolexyro wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The paste helper split clipboard content only on
\n. CR-only clipboard content was therefore inserted unchanged even though Textual displayed it as multiple rows. That left the SQL highlighter and line-oriented editing operations with malformed input. Autocomplete also split only on\n, so Textual could report a multi-row cursor location while sqlit saw a single line, causing_location_to_offsetto index past the line list.User impact
Pasted multiline SQL now uses the editor's expected LF representation, so syntax highlighting remains correct. Autocomplete also no longer crashes if CR or CRLF text reaches its cursor conversion helpers, and the cursor remains correctly positioned after applying a completion.
Fixes #292.
Validation
pytest tests/unit/test_autocomplete_cursor_positions.py tests/unit/test_query_paste.py --timeout=60: 10 passedpytest tests/unit -q --timeout=60: 1122 passed, 2 skippedruff checkon changed source and test files: passedmypyon changed source files: passedValidation ran in a Python 3.12 container.