Skip to content

Send email notification with self-service unlock link on account lockout - #656

Merged
varmar05 merged 3 commits into
developfrom
account_locked_emails
Jul 28, 2026
Merged

Send email notification with self-service unlock link on account lockout#656
varmar05 merged 3 commits into
developfrom
account_locked_emails

Conversation

@varmar05

@varmar05 varmar05 commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Alerts the account owner when repeated failed logins lock their account and lets them unlock it immediately instead of waiting out the lockout, via a token bound to the specific lock episode so it can't be reused or replayed across later lockouts.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@varmar05
varmar05 requested a review from MarcelGeo July 24, 2026 09:38
@coveralls

coveralls commented Jul 24, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 30243617257

Coverage increased (+0.06%) to 92.21%

Details

  • Coverage increased (+0.06%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (96 of 97 lines covered, 98.97%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
server/mergin/auth/app.py 32 31 96.88%
Total (5 files) 97 96 98.97%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 10269
Covered Lines: 9469
Line Coverage: 92.21%
Coverage Strength: 0.92 hits per line

💛 - Coveralls

Comment thread web-app/packages/lib/src/modules/user/views/AccountUnlockView.vue Outdated
Comment thread web-app/packages/lib/src/modules/user/views/AccountUnlockView.vue Outdated

@harminius harminius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add types to function arguments where missing

Comment thread server/mergin/auth/app.py Outdated
Comment thread server/mergin/tests/test_auth.py Outdated
@harminius
harminius dismissed MarcelGeo’s stale review July 27, 2026 13:28

comments addressed

@varmar05
varmar05 merged commit ce69919 into develop Jul 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants