fix: Refresh edition_time before return on reroot#3
Open
afonsobspinto wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://metacell.atlassian.net/browse/NA-884
This fixes a stale edition_time returned by the skeleton reroot endpoint.
During rerooting, CATMAID updates treenode parent relationships with raw SQL. The database trigger updates the new root’s edition_time, but the API response was built from the ORM object loaded before that SQL update, so clients received the pre-reroot timestamp.
The fix refreshes the rerooted treenode from the database before returning the response, so edition_time matches the persisted row. The reroot tests were updated to assert the response timestamp against the refreshed DB value, including a regression test for this specific stale timestamp case.