docs(testing): fix mobile layer placement and drop Detox E2E (MMQA-2266) - #120
Merged
Conversation
…MQA-2266) Stop agents from defaulting journeys to Appium; prefer lowest-cost layers and require written E2E justification.
Keep testing-layers.md as the single source of truth, stub layers.md, and remove Detox as an E2E layer/option from mobile-testing.
Keep layer-gate / no-Detox policy; retain main's Appium local-run playbook and docs pointers.
CI failed because changed domains/*/knowledge/* files were rejected as non-skill paths. Validate knowledge frontmatter instead of erroring.
racitores
approved these changes
Aug 12, 2026
vivek-consensys
marked this pull request as ready for review
August 12, 2026 09:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tighten MetaMask Mobile test-layer guidance so agents stop recommending Appium E2E when component-view (CV) or integration can cover the scenario, and remove Detox as an E2E layer/option.
domains/testing/knowledge/testing-layers.mdthe single source of truth; convertreferences/layers.mdto a redirect stubdetox-to-appium.md+references/detox/), and clean related coding/PR overlays + deprecated E2E stubsTicket: MMQA-2266
Type of Change
Skill Details (if adding a new skill)
Provider Name:
Skill Name:
Brief Description:
Checklist
Testing
domains/testing/knowledge/testing-layers.mdreferences/layers.mdis a stub pointing at that knowledge filemobile-testing(remainingdetoxTestID/encapsulated({ detox: ... })mentions are shared POM API names only)Additional Context
Observed issue: placement/layer skill sometimes returned “add E2E” when CV or integration would have been sufficient; only after follow-up prompts did it concede lower layers. This change makes the lowest-cost gate explicit, forbids ADD E2E without the three justification fields, and stops advertising Detox as an E2E option.