Skip to content

docs(testing): fix mobile layer placement and drop Detox E2E (MMQA-2266) - #120

Merged
vivek-consensys merged 5 commits into
mainfrom
MMQA-2266-update-test-skill
Aug 12, 2026
Merged

docs(testing): fix mobile layer placement and drop Detox E2E (MMQA-2266)#120
vivek-consensys merged 5 commits into
mainfrom
MMQA-2266-update-test-skill

Conversation

@vivek-consensys

@vivek-consensys vivek-consensys commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description

Tighten MetaMask Mobile test-layer guidance so agents stop recommending Appium E2E when component-view (CV) or integration can cover the scenario, and remove Detox as an E2E layer/option.

  • Prefer CV → integration → unit fallback → E2E
  • Require written justification for any ADD E2E (why CV insufficient, why integration insufficient, required device/native boundary)
  • Clarify that “default to Appium” means the E2E framework after E2E is justified — not the default test layer
  • Make domains/testing/knowledge/testing-layers.md the single source of truth; convert references/layers.md to a redirect stub
  • Remove Detox E2E from policy/skill routing (detox-to-appium.md + references/detox/), and clean related coding/PR overlays + deprecated E2E stubs

Ticket: MMQA-2266

Type of Change

  • New skill
  • Skill improvement/update
  • Bug fix
  • Documentation update
  • Other (please describe):

Skill Details (if adding a new skill)

Provider Name:
Skill Name:
Brief Description:

Checklist

  • I have read the CONTRIBUTING.md guidelines
  • My skill follows the SKILL_TEMPLATE.md format
  • I have tested this skill with an AI agent
  • My skill does not contain any secrets, private keys, or sensitive data
  • I have added appropriate documentation
  • My changes don't break existing skills

Testing

  • Confirmed layer policy lives only in domains/testing/knowledge/testing-layers.md
  • Confirmed references/layers.md is a stub pointing at that knowledge file
  • Confirmed Detox E2E docs/routes are removed from mobile-testing (remaining detoxTestID / encapsulated({ detox: ... }) mentions are shared POM API names only)
  • Spot-check expected outcomes:
    • Multi-screen filter/nav journey → CV
    • Real provider/controller seam → integration
    • OS permission / lifecycle / real deep-link → Appium E2E (with justification)

Additional Context

Observed issue: placement/layer skill sometimes returned “add E2E” when CV or integration would have been sufficient; only after follow-up prompts did it concede lower layers. This change makes the lowest-cost gate explicit, forbids ADD E2E without the three justification fields, and stops advertising Detox as an E2E option.

…MQA-2266)

Stop agents from defaulting journeys to Appium; prefer lowest-cost layers and require written E2E justification.
Keep testing-layers.md as the single source of truth, stub layers.md, and remove Detox as an E2E layer/option from mobile-testing.
@vivek-consensys vivek-consensys changed the title docs(testing): require CV/integration before E2E in mobile-testing (MMQA-2266) docs(testing): fix mobile layer placement and drop Detox E2E (MMQA-2266) Aug 11, 2026
Keep layer-gate / no-Detox policy; retain main's Appium local-run playbook and docs pointers.
CI failed because changed domains/*/knowledge/* files were rejected as non-skill paths. Validate knowledge frontmatter instead of erroring.
@vivek-consensys
vivek-consensys marked this pull request as ready for review August 12, 2026 09:50
@vivek-consensys
vivek-consensys merged commit 4b00c7d into main Aug 12, 2026
28 checks passed
@vivek-consensys
vivek-consensys deleted the MMQA-2266-update-test-skill branch August 12, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants