Nested key layout for archive manifests and reports#307
Open
probably-jaden wants to merge 1 commit into
Open
Conversation
Flat manifests/<run_id>.jsonl and reports/<run_id>.json keys pile every run into one folder. Add a small layout helper that nests new writes: an explicit --group (e.g. sprints/myrun) pins the folder, daily-YYYY-MM-DD run ids nest under daily/<YYYY-MM>/, everything else under adhoc/. Writers (capture --upload-manifest, ingest-traces --upload, write_run_report, write_cost_report) use the helper and gain a group parameter; the capture and ingest-traces commands gain --group. Prefix-listing readers (catalog, coverage, viewer) pick up both layouts already; exact-key manifest reads now try the nested key first and fall back to the legacy flat key, so existing archives keep working. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flat
manifests/<run_id>.jsonl/reports/<run_id>.jsonkeys pile every run into one folder. This adds a smalllayout.pyhelper and nests new writes by run family:manifests/sprints/myrun/<run_id>.jsonl)daily-YYYY-MM-DDrun ids nest underdaily/<YYYY-MM>/adhoc/Writers (
capture --upload-manifest,ingest-traces --upload,write_run_report,write_cost_report) go through the helper, and thecapture/ingest-tracescommands gain a--groupoption (e.g.--group sprints/myrun).Old archives keep working: prefix-listing readers (catalog, coverage, viewer) already pick up nested keys recursively on both the S3 and local stores (verified by test), and exact-key manifest reads (
manifest.read_blob) now try the nested candidates first, then fall back to the legacy flat key.Tests:
code_tests/unit_tests/test_agents_and_tools/test_source_archive/— 138 passed (newtest_layout.pycovers the key helpers, the reader fallback, and nested+flat pickup by catalog/coverage readers).🤖 Generated with Claude Code