fix(notification): use conversation ids for bubbles - #6486
Open
SeniorZhai wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes bubble and notification identities conversation-scoped.
Changes:
- Centralizes notification, summary, and bubble shortcut IDs.
- Updates notification posting and cancellation call sites.
- Adds unit tests for identifier stability.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
NotificationIds.kt |
Defines conversation-scoped identifiers and cancellation. |
NotificationIdsTest.kt |
Tests identifier stability. |
NotificationGenerator.kt |
Uses conversation IDs for notifications and bubbles. |
ConversationViewModel.kt |
Cancels all conversation notification IDs. |
SendService.kt |
Clears conversation notifications after reply/read. |
DecryptMessage.kt |
Clears conversation notifications during message updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| buildBubble(context, conversation, notificationBuilder, message, resource, person) | ||
| notificationManager.notify(message.messageId.hashCode(), notificationBuilder.build()) | ||
| notificationManager.notify(conversationNotificationId(message.conversationId), notificationBuilder.build()) |
| private const val SUMMARY_NOTIFICATION_ID_MASK = 0x40000000 | ||
| private const val BUBBLE_SHORTCUT_ID_PREFIX = "Bubble-" | ||
|
|
||
| fun conversationNotificationId(conversationId: String): Int = conversationId.hashCode() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.