fix(login): preserve state after activity recreation - #6516
Open
SeniorZhai wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Preserves the landing/login flow across activity recreation.
Changes:
- Avoids replacing restored fragment stacks.
- Restores mnemonic-login errors and suppresses automatic retries.
- Adds state-restoration unit tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
LandingActivity.kt |
Retains restored fragments. |
MnemonicPhraseFragment.kt |
Restores login failure information. |
LandingActivityStateRestorationTest.kt |
Tests restoration decisions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+139
to
+140
| if (shouldRequestAnonymousLogin(errorInfo)) { | ||
| anonymousRequest(words) |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
app/src/main/java/one/mixin/android/ui/landing/MnemonicPhraseFragment.kt:135
onSaveInstanceStatecan run before the in-flight coroutine reports a failure. Because this fragment's ViewModel survives configuration changes, a failure delivered between state saving and destruction remains in the ViewModel, but this Bundle-only check readsfalseand starts another anonymous request, clearing the restored error. Include the retained ViewModel state when deciding whether to retry.
val restoredRequestFailed = savedInstanceState?.getBoolean(STATE_REQUEST_FAILED) == true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.