Skip to content

fix(hooks): notify on permission prompts#2543

Open
lihailong00 wants to merge 1 commit into
MoonshotAI:mainfrom
lihailong00:codex/issue-2337-approval-hook
Open

fix(hooks): notify on permission prompts#2543
lihailong00 wants to merge 1 commit into
MoonshotAI:mainfrom
lihailong00:codex/issue-2337-approval-hook

Conversation

@lihailong00

@lihailong00 lihailong00 commented Jul 23, 2026

Copy link
Copy Markdown

Summary

  • emit the documented Notification hook with type permission_prompt when manual approval is required
  • avoid notifications for yolo, AFK, and session-cached automatic approvals
  • share hook configuration with subagent approval facades

Reproduction and verification

The regression test exercises the sole manual approval boundary and asserts exactly one documented notification payload.

  • uv run pytest tests/core/test_approval_telemetry.py tests/core/test_approval_runtime.py -q — 21 passed
  • targeted Ruff and Pyright — passed

Closes #2337


Open in Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Approval prompts should trigger a hook event

1 participant